2019-11-20 05:24:16 +09:00
import React from 'react' ;
2016-11-24 06:57:57 +09:00
import { connect } from 'react-redux' ;
import Status from '../components/status' ;
2022-12-01 01:25:36 +09:00
import { makeGetStatus , makeGetPictureInPicture , makeCustomEmojiMap } from '../selectors' ;
2016-10-25 00:11:02 +09:00
import {
replyCompose ,
2017-05-21 00:31:47 +09:00
mentionCompose ,
2018-04-10 00:09:11 +09:00
directCompose ,
2016-11-24 06:57:57 +09:00
} from '../actions/compose' ;
2016-10-25 00:11:02 +09:00
import {
reblog ,
favourite ,
2019-11-14 07:02:10 +09:00
bookmark ,
2016-10-25 00:11:02 +09:00
unreblog ,
2017-05-21 00:31:47 +09:00
unfavourite ,
2019-11-14 07:02:10 +09:00
unbookmark ,
2017-08-25 08:41:18 +09:00
pin ,
unpin ,
2022-12-01 01:25:36 +09:00
addReaction ,
removeReaction ,
2016-11-24 06:57:57 +09:00
} from '../actions/interactions' ;
2018-03-11 17:52:59 +09:00
import {
muteStatus ,
unmuteStatus ,
deleteStatus ,
hideStatus ,
revealStatus ,
Summary: fix slowness due to layout thrashing when reloading a large … (#12661)
* Summary: fix slowness due to layout thrashing when reloading a large set of status updates
in order to limit the maximum size of a status in a list view (e.g. the home timeline), so as to avoid having to scroll all the way through an abnormally large status update (see https://github.com/tootsuite/mastodon/pull/8205), the following steps are taken:
•the element containing the status is rendered in the browser
•its height is calculated, to determine if it exceeds the maximum height threshold.
Unfortunately for performance, these steps are carried out in the componentDidMount(/Update) method, which also performs style modifications on the element. The combination of height request and style modification during javascript evaluation in the browser leads to layout-thrashing, where the elements are repeatedly re-laid-out (see https://developers.google.com/web/fundamentals/performance/rendering/avoid-large-complex-layouts-and-layout-thrashing & https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Performance_best_practices_for_Firefox_fe_engineers).
The solution implemented here is to memoize the collapsed state in Redux the first time the status is seen (e.g. when fetched as part of a small batch, to populate the home timeline) , so that on subsequent re-renders, the value can be queried, rather than recalculated. This strategy is derived from https://github.com/tootsuite/mastodon/pull/4439 & https://github.com/tootsuite/mastodon/pull/4909, and should resolve https://github.com/tootsuite/mastodon/issues/12455.
Andrew Lin (https://github.com/onethreeseven) is thanked for his assistance in root cause analysis and solution brainstorming
* remove getSnapshotBeforeUpdate from status
* remove componentWillUnmount from status
* persist last-intersected status update and restore when ScrollableList is restored
e.g. when navigating from home-timeline to a status conversational thread and <Back again
* cache currently-viewing status id to avoid calling redux with identical value
* refactor collapse toggle to pass explicit boolean
2019-12-29 13:39:48 +09:00
toggleStatusCollapse ,
2022-02-10 08:15:30 +09:00
editStatus ,
2022-09-24 06:00:12 +09:00
translateStatus ,
undoStatusTranslation ,
2018-03-11 17:52:59 +09:00
} from '../actions/statuses' ;
2019-11-20 05:24:16 +09:00
import {
unmuteAccount ,
unblockAccount ,
} from '../actions/accounts' ;
import {
blockDomain ,
unblockDomain ,
} from '../actions/domain_blocks' ;
2022-08-25 11:27:47 +09:00
import {
initAddFilter ,
} from '../actions/filters' ;
2017-11-15 11:56:41 +09:00
import { initMuteModal } from '../actions/mutes' ;
2019-09-30 04:46:05 +09:00
import { initBlockModal } from '../actions/blocks' ;
2021-02-11 08:53:12 +09:00
import { initBoostModal } from '../actions/boosts' ;
2017-02-15 04:59:26 +09:00
import { initReport } from '../actions/reports' ;
2017-04-02 05:11:28 +09:00
import { openModal } from '../actions/modal' ;
2020-09-28 20:29:43 +09:00
import { deployPictureInPicture } from '../actions/picture_in_picture' ;
2019-11-20 05:24:16 +09:00
import { defineMessages , injectIntl , FormattedMessage } from 'react-intl' ;
2017-10-30 00:10:15 +09:00
import { boostModal , deleteModal } from '../initial_state' ;
2018-04-02 21:51:02 +09:00
import { showAlertForError } from '../actions/alerts' ;
2017-04-23 11:39:50 +09:00
const messages = defineMessages ( {
deleteConfirm : { id : 'confirmations.delete.confirm' , defaultMessage : 'Delete' } ,
deleteMessage : { id : 'confirmations.delete.message' , defaultMessage : 'Are you sure you want to delete this status?' } ,
2018-06-05 07:17:38 +09:00
redraftConfirm : { id : 'confirmations.redraft.confirm' , defaultMessage : 'Delete & redraft' } ,
2018-08-25 20:27:56 +09:00
redraftMessage : { id : 'confirmations.redraft.message' , defaultMessage : 'Are you sure you want to delete this status and re-draft it? Favourites and boosts will be lost, and replies to the original post will be orphaned.' } ,
2018-10-06 01:44:44 +09:00
replyConfirm : { id : 'confirmations.reply.confirm' , defaultMessage : 'Reply' } ,
replyMessage : { id : 'confirmations.reply.message' , defaultMessage : 'Replying now will overwrite the message you are currently composing. Are you sure you want to proceed?' } ,
2023-03-07 01:33:09 +09:00
editConfirm : { id : 'confirmations.edit.confirm' , defaultMessage : 'Edit' } ,
editMessage : { id : 'confirmations.edit.message' , defaultMessage : 'Editing now will overwrite the message you are currently composing. Are you sure you want to proceed?' } ,
2019-11-20 05:24:16 +09:00
blockDomainConfirm : { id : 'confirmations.domain_block.confirm' , defaultMessage : 'Hide entire domain' } ,
2017-04-23 11:39:50 +09:00
} ) ;
2016-10-25 00:11:02 +09:00
2017-02-23 00:30:09 +09:00
const makeMapStateToProps = ( ) => {
const getStatus = makeGetStatus ( ) ;
2020-12-08 03:36:36 +09:00
const getPictureInPicture = makeGetPictureInPicture ( ) ;
2016-10-25 00:11:02 +09:00
2017-02-23 00:30:09 +09:00
const mapStateToProps = ( state , props ) => ( {
2018-06-29 22:34:36 +09:00
status : getStatus ( state , props ) ,
2023-04-24 15:07:03 +09:00
nextInReplyToId : props . nextId ? state . getIn ( [ 'statuses' , props . nextId , 'in_reply_to_id' ] ) : null ,
2020-12-08 03:36:36 +09:00
pictureInPicture : getPictureInPicture ( state , props ) ,
2022-12-01 01:25:36 +09:00
emojiMap : makeCustomEmojiMap ( state ) ,
2016-10-25 00:11:02 +09:00
} ) ;
return mapStateToProps ;
} ;
2022-08-25 11:27:47 +09:00
const mapDispatchToProps = ( dispatch , { intl , contextType } ) => ( {
2016-10-25 00:11:02 +09:00
2016-11-21 18:52:11 +09:00
onReply ( status , router ) {
2018-10-06 01:44:44 +09:00
dispatch ( ( _ , getState ) => {
let state = getState ( ) ;
2019-09-22 03:01:16 +09:00
2018-10-06 01:44:44 +09:00
if ( state . getIn ( [ 'compose' , 'text' ] ) . trim ( ) . length !== 0 ) {
dispatch ( openModal ( 'CONFIRM' , {
message : intl . formatMessage ( messages . replyMessage ) ,
confirm : intl . formatMessage ( messages . replyConfirm ) ,
onConfirm : ( ) => dispatch ( replyCompose ( status , router ) ) ,
} ) ) ;
} else {
dispatch ( replyCompose ( status , router ) ) ;
}
} ) ;
2016-10-25 00:11:02 +09:00
} ,
2021-02-11 08:53:12 +09:00
onModalReblog ( status , privacy ) {
2019-05-10 05:39:27 +09:00
if ( status . get ( 'reblogged' ) ) {
dispatch ( unreblog ( status ) ) ;
} else {
2021-02-11 08:53:12 +09:00
dispatch ( reblog ( status , privacy ) ) ;
2019-05-10 05:39:27 +09:00
}
2017-04-11 11:28:52 +09:00
} ,
2017-04-11 21:34:14 +09:00
onReblog ( status , e ) {
2019-07-22 01:11:09 +09:00
if ( ( e && e . shiftKey ) || ! boostModal ) {
2019-05-10 05:39:27 +09:00
this . onModalReblog ( status ) ;
2016-10-25 00:11:02 +09:00
} else {
2021-02-11 08:53:12 +09:00
dispatch ( initBoostModal ( { status , onReblog : this . onModalReblog } ) ) ;
2016-10-25 00:11:02 +09:00
}
} ,
onFavourite ( status ) {
if ( status . get ( 'favourited' ) ) {
dispatch ( unfavourite ( status ) ) ;
} else {
dispatch ( favourite ( status ) ) ;
}
} ,
2019-11-14 07:02:10 +09:00
onBookmark ( status ) {
if ( status . get ( 'bookmarked' ) ) {
dispatch ( unbookmark ( status ) ) ;
} else {
dispatch ( bookmark ( status ) ) ;
}
} ,
2017-08-25 08:41:18 +09:00
onPin ( status ) {
if ( status . get ( 'pinned' ) ) {
dispatch ( unpin ( status ) ) ;
} else {
dispatch ( pin ( status ) ) ;
}
} ,
2022-12-04 01:20:29 +09:00
onReactionAdd ( statusId , name , url ) {
dispatch ( addReaction ( statusId , name , url ) ) ;
2022-12-01 01:25:36 +09:00
} ,
onReactionRemove ( statusId , name ) {
dispatch ( removeReaction ( statusId , name ) ) ;
} ,
2017-09-02 04:30:13 +09:00
onEmbed ( status ) {
2018-04-02 21:51:02 +09:00
dispatch ( openModal ( 'EMBED' , {
url : status . get ( 'url' ) ,
onError : error => dispatch ( showAlertForError ( error ) ) ,
} ) ) ;
2017-09-02 04:30:13 +09:00
} ,
2018-08-19 10:17:01 +09:00
onDelete ( status , history , withRedraft = false ) {
2017-10-30 00:10:15 +09:00
if ( ! deleteModal ) {
2018-08-19 10:17:01 +09:00
dispatch ( deleteStatus ( status . get ( 'id' ) , history , withRedraft ) ) ;
2017-05-30 00:56:13 +09:00
} else {
dispatch ( openModal ( 'CONFIRM' , {
2018-06-05 07:17:38 +09:00
message : intl . formatMessage ( withRedraft ? messages . redraftMessage : messages . deleteMessage ) ,
confirm : intl . formatMessage ( withRedraft ? messages . redraftConfirm : messages . deleteConfirm ) ,
2018-08-19 10:17:01 +09:00
onConfirm : ( ) => dispatch ( deleteStatus ( status . get ( 'id' ) , history , withRedraft ) ) ,
2017-05-30 00:56:13 +09:00
} ) ) ;
}
2016-10-25 00:11:02 +09:00
} ,
2022-02-10 08:15:30 +09:00
onEdit ( status , history ) {
2023-03-07 01:33:09 +09:00
dispatch ( ( _ , getState ) => {
let state = getState ( ) ;
if ( state . getIn ( [ 'compose' , 'text' ] ) . trim ( ) . length !== 0 ) {
dispatch ( openModal ( 'CONFIRM' , {
message : intl . formatMessage ( messages . editMessage ) ,
confirm : intl . formatMessage ( messages . editConfirm ) ,
onConfirm : ( ) => dispatch ( editStatus ( status . get ( 'id' ) , history ) ) ,
} ) ) ;
} else {
dispatch ( editStatus ( status . get ( 'id' ) , history ) ) ;
}
} ) ;
2022-02-10 08:15:30 +09:00
} ,
2022-09-24 06:00:12 +09:00
onTranslate ( status ) {
if ( status . get ( 'translation' ) ) {
dispatch ( undoStatusTranslation ( status . get ( 'id' ) ) ) ;
} else {
dispatch ( translateStatus ( status . get ( 'id' ) ) ) ;
}
} ,
2018-04-10 00:09:11 +09:00
onDirect ( account , router ) {
dispatch ( directCompose ( account , router ) ) ;
} ,
2017-01-08 19:04:01 +09:00
onMention ( account , router ) {
2017-01-31 05:40:55 +09:00
dispatch ( mentionCompose ( account , router ) ) ;
2016-10-25 01:07:40 +09:00
} ,
2023-05-11 19:41:55 +09:00
onOpenMedia ( statusId , media , index , lang ) {
dispatch ( openModal ( 'MEDIA' , { statusId , media , index , lang } ) ) ;
2016-11-24 06:57:57 +09:00
} ,
2023-05-11 19:41:55 +09:00
onOpenVideo ( statusId , media , lang , options ) {
dispatch ( openModal ( 'VIDEO' , { statusId , media , lang , options } ) ) ;
2017-04-13 22:04:18 +09:00
} ,
2019-03-27 01:34:02 +09:00
onBlock ( status ) {
const account = status . get ( 'account' ) ;
2019-09-30 04:46:05 +09:00
dispatch ( initBlockModal ( account ) ) ;
2017-02-15 04:59:26 +09:00
} ,
2019-11-20 05:24:16 +09:00
onUnblock ( account ) {
dispatch ( unblockAccount ( account . get ( 'id' ) ) ) ;
} ,
2017-02-15 04:59:26 +09:00
onReport ( status ) {
dispatch ( initReport ( status . get ( 'account' ) , status ) ) ;
2017-02-06 10:51:56 +09:00
} ,
2022-08-25 11:27:47 +09:00
onAddFilter ( status ) {
dispatch ( initAddFilter ( status , { contextType } ) ) ;
} ,
2017-02-06 10:51:56 +09:00
onMute ( account ) {
2017-11-15 11:56:41 +09:00
dispatch ( initMuteModal ( account ) ) ;
2017-02-06 10:51:56 +09:00
} ,
2016-10-25 00:11:02 +09:00
2019-11-20 05:24:16 +09:00
onUnmute ( account ) {
dispatch ( unmuteAccount ( account . get ( 'id' ) ) ) ;
} ,
Feature conversations muting (#3017)
* Add <ostatus:conversation /> tag to Atom input/output
Only uses ref attribute (not href) because href would be
the alternate link that's always included also.
Creates new conversation for every non-reply status. Carries
over conversation for every reply. Keeps remote URIs verbatim,
generates local URIs on the fly like the rest of them.
* Conversation muting - prevents notifications that reference a conversation
(including replies, favourites, reblogs) from being created. API endpoints
/api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute
Currently no way to tell when a status/conversation is muted, so the web UI
only has a "disable notifications" button, doesn't work as a toggle
* Display "Dismiss notifications" on all statuses in notifications column, not just own
* Add "muted" as a boolean attribute on statuses JSON
For now always false on contained reblogs, since it's only relevant for
statuses returned from the notifications endpoint, which are not nested
Remove "Disable notifications" from detailed status view, since it's
only relevant in the notifications column
* Up max class length
* Remove pending test for conversation mute
* Add tests, clean up
* Rename to "mute conversation" and "unmute conversation"
* Raise validation error when trying to mute/unmute status without conversation
2017-05-15 10:04:13 +09:00
onMuteConversation ( status ) {
if ( status . get ( 'muted' ) ) {
dispatch ( unmuteStatus ( status . get ( 'id' ) ) ) ;
} else {
dispatch ( muteStatus ( status . get ( 'id' ) ) ) ;
}
} ,
2018-03-11 17:52:59 +09:00
onToggleHidden ( status ) {
if ( status . get ( 'hidden' ) ) {
dispatch ( revealStatus ( status . get ( 'id' ) ) ) ;
} else {
dispatch ( hideStatus ( status . get ( 'id' ) ) ) ;
}
} ,
Summary: fix slowness due to layout thrashing when reloading a large … (#12661)
* Summary: fix slowness due to layout thrashing when reloading a large set of status updates
in order to limit the maximum size of a status in a list view (e.g. the home timeline), so as to avoid having to scroll all the way through an abnormally large status update (see https://github.com/tootsuite/mastodon/pull/8205), the following steps are taken:
•the element containing the status is rendered in the browser
•its height is calculated, to determine if it exceeds the maximum height threshold.
Unfortunately for performance, these steps are carried out in the componentDidMount(/Update) method, which also performs style modifications on the element. The combination of height request and style modification during javascript evaluation in the browser leads to layout-thrashing, where the elements are repeatedly re-laid-out (see https://developers.google.com/web/fundamentals/performance/rendering/avoid-large-complex-layouts-and-layout-thrashing & https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Performance_best_practices_for_Firefox_fe_engineers).
The solution implemented here is to memoize the collapsed state in Redux the first time the status is seen (e.g. when fetched as part of a small batch, to populate the home timeline) , so that on subsequent re-renders, the value can be queried, rather than recalculated. This strategy is derived from https://github.com/tootsuite/mastodon/pull/4439 & https://github.com/tootsuite/mastodon/pull/4909, and should resolve https://github.com/tootsuite/mastodon/issues/12455.
Andrew Lin (https://github.com/onethreeseven) is thanked for his assistance in root cause analysis and solution brainstorming
* remove getSnapshotBeforeUpdate from status
* remove componentWillUnmount from status
* persist last-intersected status update and restore when ScrollableList is restored
e.g. when navigating from home-timeline to a status conversational thread and <Back again
* cache currently-viewing status id to avoid calling redux with identical value
* refactor collapse toggle to pass explicit boolean
2019-12-29 13:39:48 +09:00
onToggleCollapsed ( status , isCollapsed ) {
dispatch ( toggleStatusCollapse ( status . get ( 'id' ) , isCollapsed ) ) ;
} ,
2019-11-20 05:24:16 +09:00
onBlockDomain ( domain ) {
dispatch ( openModal ( 'CONFIRM' , {
message : < FormattedMessage id = 'confirmations.domain_block.message' defaultMessage = 'Are you really, really sure you want to block the entire {domain}? In most cases a few targeted blocks or mutes are sufficient and preferable. You will not see content from that domain in any public timelines or your notifications. Your followers from that domain will be removed.' values = { { domain : < strong > { domain } < / strong > } } / > ,
confirm : intl . formatMessage ( messages . blockDomainConfirm ) ,
onConfirm : ( ) => dispatch ( blockDomain ( domain ) ) ,
} ) ) ;
} ,
onUnblockDomain ( domain ) {
dispatch ( unblockDomain ( domain ) ) ;
} ,
2020-09-28 20:29:43 +09:00
deployPictureInPicture ( status , type , mediaProps ) {
dispatch ( deployPictureInPicture ( status . get ( 'id' ) , status . getIn ( [ 'account' , 'id' ] ) , type , mediaProps ) ) ;
} ,
2022-10-07 17:14:31 +09:00
onInteractionModal ( type , status ) {
dispatch ( openModal ( 'INTERACTION' , {
type ,
accountId : status . getIn ( [ 'account' , 'id' ] ) ,
url : status . get ( 'url' ) ,
} ) ) ;
} ,
2016-10-25 00:11:02 +09:00
} ) ;
2017-04-23 11:39:50 +09:00
export default injectIntl ( connect ( makeMapStateToProps , mapDispatchToProps ) ( Status ) ) ;