diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 244f030758..969aa53e80 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -212,10 +212,6 @@ RSpec/MultipleMemoizedHelpers: RSpec/NestedGroups: Max: 6 -RSpec/PendingWithoutReason: - Exclude: - - 'spec/models/status_reaction_spec.rb' - # This cop supports unsafe autocorrection (--autocorrect-all). Rails/ApplicationController: Exclude: diff --git a/app/controllers/api/v1/custom_emojis_controller.rb b/app/controllers/api/v1/custom_emojis_controller.rb index 4c056c952e..76bc2b18ad 100644 --- a/app/controllers/api/v1/custom_emojis_controller.rb +++ b/app/controllers/api/v1/custom_emojis_controller.rb @@ -2,7 +2,6 @@ class Api::V1::CustomEmojisController < Api::BaseController vary_by '', unless: :disallow_unauthenticated_api_access? - skip_before_action :require_authenticated_user!, unless: :whitelist_mode? def index cache_even_if_authenticated! unless disallow_unauthenticated_api_access? diff --git a/app/javascript/mastodon/containers/status_container.jsx b/app/javascript/mastodon/containers/status_container.jsx index 83a161b74d..722a35568d 100644 --- a/app/javascript/mastodon/containers/status_container.jsx +++ b/app/javascript/mastodon/containers/status_container.jsx @@ -50,7 +50,7 @@ import { } from '../actions/statuses'; import Status from '../components/status'; import { boostModal, deleteModal } from '../initial_state'; -import { makeGetStatus, makeGetPictureInPicture, makeCustomEmojiMap } from '../selectors'; +import { makeGetStatus, makeGetPictureInPicture } from '../selectors'; const messages = defineMessages({ deleteConfirm: { id: 'confirmations.delete.confirm', defaultMessage: 'Delete' }, @@ -72,7 +72,6 @@ const makeMapStateToProps = () => { status: getStatus(state, props), nextInReplyToId: props.nextId ? state.getIn(['statuses', props.nextId, 'in_reply_to_id']) : null, pictureInPicture: getPictureInPicture(state, props), - emojiMap: makeCustomEmojiMap(state), }); return mapStateToProps; diff --git a/app/javascript/mastodon/features/status/index.jsx b/app/javascript/mastodon/features/status/index.jsx index 79594a7c07..4b82ae4296 100644 --- a/app/javascript/mastodon/features/status/index.jsx +++ b/app/javascript/mastodon/features/status/index.jsx @@ -67,7 +67,7 @@ import ColumnHeader from '../../components/column_header'; import { textForScreenReader, defaultMediaVisibility } from '../../components/status'; import StatusContainer from '../../containers/status_container'; import { boostModal, deleteModal } from '../../initial_state'; -import { makeCustomEmojiMap, makeGetStatus, makeGetPictureInPicture } from '../../selectors'; +import { makeGetStatus, makeGetPictureInPicture } from '../../selectors'; import Column from '../ui/components/column'; import { attachFullscreenListener, detachFullscreenListener, isFullscreen } from '../ui/util/fullscreen'; @@ -166,7 +166,6 @@ const makeMapStateToProps = () => { askReplyConfirmation: state.getIn(['compose', 'text']).trim().length !== 0, domain: state.getIn(['meta', 'domain']), pictureInPicture: getPictureInPicture(state, { id: props.params.statusId }), - emojiMap: makeCustomEmojiMap(state), }; }; diff --git a/app/javascript/mastodon/selectors/index.js b/app/javascript/mastodon/selectors/index.js index 5490f7815b..0968fb090b 100644 --- a/app/javascript/mastodon/selectors/index.js +++ b/app/javascript/mastodon/selectors/index.js @@ -128,14 +128,6 @@ export const getAccountHidden = createSelector([ return hidden && !(isSelf || followingOrRequested); }); -export const makeCustomEmojiMap = createSelector( - [state => state.get('custom_emojis')], - items => items.reduce( - (map, emoji) => map.set(emoji.get('shortcode'), emoji), - ImmutableMap(), - ), -); - export const getStatusList = createSelector([ (state, type) => state.getIn(['status_lists', type, 'items']), ], (items) => items.toList()); diff --git a/app/javascript/styles/mastodon/components.scss b/app/javascript/styles/mastodon/components.scss index 1cb1606dd8..614ad2439d 100644 --- a/app/javascript/styles/mastodon/components.scss +++ b/app/javascript/styles/mastodon/components.scss @@ -1118,10 +1118,6 @@ body > [data-popper-placement] { } } - .reactions-bar--empty { - margin-top: 0; - } - &--in-thread { $thread-margin: 46px + 10px;