namekuji/chuckya
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Refactor status reactions query

Browse source 
This was done to announcement reactions in 1b0cb3b54d. Might as well do it here too.
This commit is contained in:
Essem 2024-01-24 17:50:58 -06:00
parent a12b2ad57a
commit aae6e1b1fd
No known key found for this signature in database
GPG key ID: 7D497397CC3A2A8C
1 changed files with 34 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
app/models/status.rb
View file

@ -283,20 +283,13 @@ class Status < ApplicationRecord
end end
def reactions(account = nil) def reactions(account = nil)
records = begin grouped_ordered_status_reactions.select(
scope = status_reactions.group(:status_id, :name, :custom_emoji_id).order(Arel.sql('MIN(created_at) ASC')) [:name, :custom_emoji_id, 'COUNT(*) as count'].tap do |values|
values << value_for_reaction_me_column(account)
if account.nil?
scope.select('name, custom_emoji_id, count(*) as count, false as me')
else
# rubocop:disable Layout/LineLength
scope.select("name, custom_emoji_id, count(*) as count, exists(select 1 from status_reactions r where r.account_id = #{account.id} and r.status_id = status_reactions.status_id and r.name = status_reactions.name and (r.custom_emoji_id = status_reactions.custom_emoji_id or r.custom_emoji_id is null and status_reactions.custom_emoji_id is null)) as me")
# rubocop:enable Layout/LineLength
end end
).to_a.tap do |records|
ActiveRecord::Associations::Preloader.new(records: records, associations: :custom_emoji).call
end end
ActiveRecord::Associations::Preloader.new(records: records, associations: :custom_emoji)
records
end end
def ordered_media_attachments def ordered_media_attachments
@ -486,6 +479,35 @@ class Status < ApplicationRecord
private private
def grouped_ordered_status_reactions
status_reactions
.group(:status_id, :name, :custom_emoji_id)
.order(
Arel.sql('MIN(created_at)').asc
)
end
def value_for_reaction_me_column(account)
if account.nil?
'FALSE AS me'
else
<<~SQL.squish
EXISTS(
SELECT 1
FROM status_reactions inner_reactions
WHERE inner_reactions.account_id = #{account.id}
AND inner_reactions.status_id = status_reactions.status_id
AND inner_reactions.name = status_reactions.name
AND (
inner_reactions.custom_emoji_id = status_reactions.custom_emoji_id
OR inner_reactions.custom_emoji_id IS NULL
AND status_reactions.custom_emoji_id IS NULL
)
) AS me
SQL
end
end
def update_status_stat!(attrs) def update_status_stat!(attrs)
return if marked_for_destruction? || destroyed? return if marked_for_destruction? || destroyed?