From c53ff0feccf167a939d7e16e49adf45c2acc3630 Mon Sep 17 00:00:00 2001
From: fef <owo@fef.moe>
Date: Thu, 1 Dec 2022 23:30:39 +0100
Subject: [PATCH] cleanup JS imports and other minor stuff

---
 .../flavours/glitch/actions/interactions.js           |  6 ------
 .../flavours/glitch/components/status_reactions.js    | 10 +---------
 .../glitch/features/local_settings/page/index.jsx     |  1 -
 .../features/local_settings/page/item/index.jsx       | 11 +++++------
 .../features/status/components/detailed_status.jsx    |  2 +-
 .../flavours/glitch/features/status/index.jsx         |  2 +-
 app/javascript/flavours/glitch/initial_state.js       |  3 ++-
 app/javascript/mastodon/actions/interactions.js       |  6 ------
 app/javascript/mastodon/components/status.jsx         |  3 +--
 .../mastodon/components/status_reactions.js           | 10 +---------
 .../features/status/components/detailed_status.jsx    |  2 +-
 app/javascript/mastodon/features/status/index.jsx     |  2 +-
 app/javascript/mastodon/initial_state.js              |  2 +-
 13 files changed, 15 insertions(+), 45 deletions(-)

diff --git a/app/javascript/flavours/glitch/actions/interactions.js b/app/javascript/flavours/glitch/actions/interactions.js
index dbcf13ec41..061e0c252c 100644
--- a/app/javascript/flavours/glitch/actions/interactions.js
+++ b/app/javascript/flavours/glitch/actions/interactions.js
@@ -429,14 +429,12 @@ export const addReactionRequest = (statusId, name) => ({
   type: REACTION_ADD_REQUEST,
   id: statusId,
   name,
-  skipLoading: true,
 });
 
 export const addReactionSuccess = (statusId, name) => ({
   type: REACTION_ADD_SUCCESS,
   id: statusId,
   name,
-  skipLoading: true,
 });
 
 export const addReactionFail = (statusId, name, error) => ({
@@ -444,7 +442,6 @@ export const addReactionFail = (statusId, name, error) => ({
   id: statusId,
   name,
   error,
-  skipLoading: true,
 });
 
 export const removeReaction = (statusId, name) => (dispatch, getState) => {
@@ -461,19 +458,16 @@ export const removeReactionRequest = (statusId, name) => ({
   type: REACTION_REMOVE_REQUEST,
   id: statusId,
   name,
-  skipLoading: true,
 });
 
 export const removeReactionSuccess = (statusId, name) => ({
   type: REACTION_REMOVE_SUCCESS,
   id: statusId,
   name,
-  skipLoading: true,
 });
 
 export const removeReactionFail = (statusId, name) => ({
   type: REACTION_REMOVE_FAIL,
   id: statusId,
   name,
-  skipLoading: true,
 });
diff --git a/app/javascript/flavours/glitch/components/status_reactions.js b/app/javascript/flavours/glitch/components/status_reactions.js
index df2a686abd..63ec7941cb 100644
--- a/app/javascript/flavours/glitch/components/status_reactions.js
+++ b/app/javascript/flavours/glitch/components/status_reactions.js
@@ -1,7 +1,7 @@
 import ImmutablePureComponent from 'react-immutable-pure-component';
 import PropTypes from 'prop-types';
 import ImmutablePropTypes from 'react-immutable-proptypes';
-import { reduceMotion } from '../initial_state';
+import { autoPlayGif, reduceMotion } from '../initial_state';
 import spring from 'react-motion/lib/spring';
 import TransitionMotion from 'react-motion/lib/TransitionMotion';
 import classNames from 'classnames';
@@ -9,7 +9,6 @@ import React from 'react';
 import unicodeMapping from '../features/emoji/emoji_unicode_mapping_light';
 import AnimatedNumber from './animated_number';
 import { assetHost } from '../utils/config';
-import { autoPlayGif } from '../initial_state';
 
 export default class StatusReactions extends ImmutablePureComponent {
 
@@ -101,19 +100,12 @@ class Reaction extends ImmutablePureComponent {
   render() {
     const { reaction } = this.props;
 
-    let shortCode = reaction.get('name');
-
-    if (unicodeMapping[shortCode]) {
-      shortCode = unicodeMapping[shortCode].shortCode;
-    }
-
     return (
       <button
         className={classNames('reactions-bar__item', { active: reaction.get('me') })}
         onClick={this.handleClick}
         onMouseEnter={this.handleMouseEnter}
         onMouseLeave={this.handleMouseLeave}
-        title={`:${shortCode}:`}
         style={this.props.style}
       >
         <span className='reactions-bar__item__emoji'>
diff --git a/app/javascript/flavours/glitch/features/local_settings/page/index.jsx b/app/javascript/flavours/glitch/features/local_settings/page/index.jsx
index 8669ee8081..91582a3183 100644
--- a/app/javascript/flavours/glitch/features/local_settings/page/index.jsx
+++ b/app/javascript/flavours/glitch/features/local_settings/page/index.jsx
@@ -33,7 +33,6 @@ const messages = defineMessages({
   unlisted: { id: 'privacy.unlisted.short', defaultMessage: 'Unlisted' },
   private: { id: 'privacy.private.short', defaultMessage: 'Followers-only' },
   direct: { id: 'privacy.direct.short', defaultMessage: 'Mentioned people only' },
-  enter_amount_prompt: { id: 'settings.enter_amount_prompt', defaultMessage: 'Enter an amount' },
 });
 
 class LocalSettingsPage extends React.PureComponent {
diff --git a/app/javascript/flavours/glitch/features/local_settings/page/item/index.jsx b/app/javascript/flavours/glitch/features/local_settings/page/item/index.jsx
index 9391200799..99bb65ca03 100644
--- a/app/javascript/flavours/glitch/features/local_settings/page/item/index.jsx
+++ b/app/javascript/flavours/glitch/features/local_settings/page/item/index.jsx
@@ -22,21 +22,20 @@ export default class LocalSettingsPageItem extends React.PureComponent {
     })),
     settings: ImmutablePropTypes.map.isRequired,
     placeholder: PropTypes.string,
-    number: PropTypes.bool,
     disabled: PropTypes.bool,
   };
 
   handleChange = e => {
     const { target } = e;
-    const { item, onChange, options, placeholder, number } = this.props;
+    const { item, onChange, options, placeholder } = this.props;
     if (options && options.length > 0) onChange(item, target.value);
-    else if (placeholder) onChange(item, number ? parseInt(target.value) : target.value);
+    else if (placeholder) onChange(item, target.value);
     else onChange(item, target.checked);
   };
 
   render () {
     const { handleChange } = this;
-    const { settings, item, id, inputProps, options, children, dependsOn, dependsOnNot, placeholder, number, disabled } = this.props;
+    const { settings, item, id, inputProps, options, children, dependsOn, dependsOnNot, placeholder, disabled } = this.props;
     let enabled = !disabled;
 
     if (dependsOn) {
@@ -80,7 +79,7 @@ export default class LocalSettingsPageItem extends React.PureComponent {
           </fieldset>
         </div>
       );
-    } else if (placeholder || number) {
+    } else if (placeholder) {
       return (
         <div className='glitch local-settings__page__item string'>
           <label htmlFor={id}>
@@ -88,7 +87,7 @@ export default class LocalSettingsPageItem extends React.PureComponent {
             <p>
               <input
                 id={id}
-                type={number ? 'number' : 'text'}
+                type='text'
                 value={settings.getIn(item)}
                 placeholder={placeholder}
                 onChange={handleChange}
diff --git a/app/javascript/flavours/glitch/features/status/components/detailed_status.jsx b/app/javascript/flavours/glitch/features/status/components/detailed_status.jsx
index fca0548da1..0e7f1c26f7 100644
--- a/app/javascript/flavours/glitch/features/status/components/detailed_status.jsx
+++ b/app/javascript/flavours/glitch/features/status/components/detailed_status.jsx
@@ -20,7 +20,7 @@ import Icon from 'flavours/glitch/components/icon';
 import AnimatedNumber from 'flavours/glitch/components/animated_number';
 import PictureInPicturePlaceholder from 'flavours/glitch/components/picture_in_picture_placeholder';
 import EditedTimestamp from 'flavours/glitch/components/edited_timestamp';
-import StatusReactions from '../../../components/status_reactions';
+import StatusReactions from 'flavours/glitch/components/status_reactions';
 
 class DetailedStatus extends ImmutablePureComponent {
 
diff --git a/app/javascript/flavours/glitch/features/status/index.jsx b/app/javascript/flavours/glitch/features/status/index.jsx
index 538c830d8f..46639b01ec 100644
--- a/app/javascript/flavours/glitch/features/status/index.jsx
+++ b/app/javascript/flavours/glitch/features/status/index.jsx
@@ -42,7 +42,7 @@ import { initMuteModal } from 'flavours/glitch/actions/mutes';
 import { initBlockModal } from 'flavours/glitch/actions/blocks';
 import { initReport } from 'flavours/glitch/actions/reports';
 import { initBoostModal } from 'flavours/glitch/actions/boosts';
-import { makeGetStatus, makeGetPictureInPicture } from 'flavours/glitch/selectors';
+import { makeCustomEmojiMap, makeGetStatus, makeGetPictureInPicture } from 'flavours/glitch/selectors';
 import ScrollContainer from 'flavours/glitch/containers/scroll_container';
 import ColumnHeader from '../../components/column_header';
 import StatusContainer from 'flavours/glitch/containers/status_container';
diff --git a/app/javascript/flavours/glitch/initial_state.js b/app/javascript/flavours/glitch/initial_state.js
index fb3d05f6eb..1744f6a395 100644
--- a/app/javascript/flavours/glitch/initial_state.js
+++ b/app/javascript/flavours/glitch/initial_state.js
@@ -62,6 +62,7 @@
  * @property {boolean} limited_federation_mode
  * @property {string} locale
  * @property {string | null} mascot
+ * @property {number} max_reactions
  * @property {string=} me
  * @property {string=} moved_to_account_id
  * @property {string=} owner
@@ -81,6 +82,7 @@
  * @property {boolean} use_blurhash
  * @property {boolean=} use_pending_items
  * @property {string} version
+ * @property {number} visible_reactions
  * @property {boolean} translation_enabled
  * @property {string} status_page_url
  * @property {boolean} system_emoji_font
@@ -134,7 +136,6 @@ export const mascot = getMeta('mascot');
 export const maxReactions = (initialState && initialState.max_reactions) || 1;
 export const me = getMeta('me');
 export const movedToAccountId = getMeta('moved_to_account_id');
-export const visibleReactions = getMeta('visible_reactions');
 export const owner = getMeta('owner');
 export const profile_directory = getMeta('profile_directory');
 export const reduceMotion = getMeta('reduce_motion');
diff --git a/app/javascript/mastodon/actions/interactions.js b/app/javascript/mastodon/actions/interactions.js
index 8f2335ce95..fc9a8fdd5b 100644
--- a/app/javascript/mastodon/actions/interactions.js
+++ b/app/javascript/mastodon/actions/interactions.js
@@ -449,14 +449,12 @@ export const addReactionRequest = (statusId, name) => ({
   type: REACTION_ADD_REQUEST,
   id: statusId,
   name,
-  skipLoading: true,
 });
 
 export const addReactionSuccess = (statusId, name) => ({
   type: REACTION_ADD_SUCCESS,
   id: statusId,
   name,
-  skipLoading: true,
 });
 
 export const addReactionFail = (statusId, name, error) => ({
@@ -464,7 +462,6 @@ export const addReactionFail = (statusId, name, error) => ({
   id: statusId,
   name,
   error,
-  skipLoading: true,
 });
 
 export const removeReaction = (statusId, name) => (dispatch, getState) => {
@@ -481,19 +478,16 @@ export const removeReactionRequest = (statusId, name) => ({
   type: REACTION_REMOVE_REQUEST,
   id: statusId,
   name,
-  skipLoading: true,
 });
 
 export const removeReactionSuccess = (statusId, name) => ({
   type: REACTION_REMOVE_SUCCESS,
   id: statusId,
   name,
-  skipLoading: true,
 });
 
 export const removeReactionFail = (statusId, name) => ({
   type: REACTION_REMOVE_FAIL,
   id: statusId,
   name,
-  skipLoading: true,
 });
diff --git a/app/javascript/mastodon/components/status.jsx b/app/javascript/mastodon/components/status.jsx
index a60d0ec026..74bd56fe8b 100644
--- a/app/javascript/mastodon/components/status.jsx
+++ b/app/javascript/mastodon/components/status.jsx
@@ -16,13 +16,12 @@ import { MediaGallery, Video, Audio } from '../features/ui/util/async-components
 import { HotKeys } from 'react-hotkeys';
 import classNames from 'classnames';
 import Icon from 'mastodon/components/icon';
-import { displayMedia } from '../initial_state';
+import { displayMedia, visibleReactions } from '../initial_state';
 import PictureInPicturePlaceholder from 'mastodon/components/picture_in_picture_placeholder';
 
 // We use the component (and not the container) since we do not want
 // to use the progress bar to show download progress
 import Bundle from '../features/ui/components/bundle';
-import { visibleReactions } from '../initial_state';
 
 export const textForScreenReader = (intl, status, rebloggedByText = false) => {
   const displayName = status.getIn(['account', 'display_name']);
diff --git a/app/javascript/mastodon/components/status_reactions.js b/app/javascript/mastodon/components/status_reactions.js
index df2a686abd..63ec7941cb 100644
--- a/app/javascript/mastodon/components/status_reactions.js
+++ b/app/javascript/mastodon/components/status_reactions.js
@@ -1,7 +1,7 @@
 import ImmutablePureComponent from 'react-immutable-pure-component';
 import PropTypes from 'prop-types';
 import ImmutablePropTypes from 'react-immutable-proptypes';
-import { reduceMotion } from '../initial_state';
+import { autoPlayGif, reduceMotion } from '../initial_state';
 import spring from 'react-motion/lib/spring';
 import TransitionMotion from 'react-motion/lib/TransitionMotion';
 import classNames from 'classnames';
@@ -9,7 +9,6 @@ import React from 'react';
 import unicodeMapping from '../features/emoji/emoji_unicode_mapping_light';
 import AnimatedNumber from './animated_number';
 import { assetHost } from '../utils/config';
-import { autoPlayGif } from '../initial_state';
 
 export default class StatusReactions extends ImmutablePureComponent {
 
@@ -101,19 +100,12 @@ class Reaction extends ImmutablePureComponent {
   render() {
     const { reaction } = this.props;
 
-    let shortCode = reaction.get('name');
-
-    if (unicodeMapping[shortCode]) {
-      shortCode = unicodeMapping[shortCode].shortCode;
-    }
-
     return (
       <button
         className={classNames('reactions-bar__item', { active: reaction.get('me') })}
         onClick={this.handleClick}
         onMouseEnter={this.handleMouseEnter}
         onMouseLeave={this.handleMouseLeave}
-        title={`:${shortCode}:`}
         style={this.props.style}
       >
         <span className='reactions-bar__item__emoji'>
diff --git a/app/javascript/mastodon/features/status/components/detailed_status.jsx b/app/javascript/mastodon/features/status/components/detailed_status.jsx
index 809e23ac5e..b5216b2227 100644
--- a/app/javascript/mastodon/features/status/components/detailed_status.jsx
+++ b/app/javascript/mastodon/features/status/components/detailed_status.jsx
@@ -17,7 +17,7 @@ import Icon from 'mastodon/components/icon';
 import AnimatedNumber from 'mastodon/components/animated_number';
 import PictureInPicturePlaceholder from 'mastodon/components/picture_in_picture_placeholder';
 import EditedTimestamp from 'mastodon/components/edited_timestamp';
-import StatusReactions from '../../../components/status_reactions';
+import StatusReactions from 'mastodon/components/status_reactions';
 
 const messages = defineMessages({
   public_short: { id: 'privacy.public.short', defaultMessage: 'Public' },
diff --git a/app/javascript/mastodon/features/status/index.jsx b/app/javascript/mastodon/features/status/index.jsx
index c183c1f90d..92563b2717 100644
--- a/app/javascript/mastodon/features/status/index.jsx
+++ b/app/javascript/mastodon/features/status/index.jsx
@@ -49,7 +49,7 @@ import { initMuteModal } from '../../actions/mutes';
 import { initBlockModal } from '../../actions/blocks';
 import { initBoostModal } from '../../actions/boosts';
 import { initReport } from '../../actions/reports';
-import { makeGetStatus, makeGetPictureInPicture } from '../../selectors';
+import { makeCustomEmojiMap, makeGetStatus, makeGetPictureInPicture } from '../../selectors';
 import ScrollContainer from 'mastodon/containers/scroll_container';
 import ColumnHeader from '../../components/column_header';
 import StatusContainer from '../../containers/status_container';
diff --git a/app/javascript/mastodon/initial_state.js b/app/javascript/mastodon/initial_state.js
index 5249e8ec1f..ac71e302a5 100644
--- a/app/javascript/mastodon/initial_state.js
+++ b/app/javascript/mastodon/initial_state.js
@@ -61,6 +61,7 @@
  * @property {boolean} limited_federation_mode
  * @property {string} locale
  * @property {string | null} mascot
+ * @property {number} max_reactions
  * @property {string=} me
  * @property {string=} moved_to_account_id
  * @property {string=} owner
@@ -117,7 +118,6 @@ export const mascot = getMeta('mascot');
 export const maxReactions = (initialState && initialState.max_reactions) || 1;
 export const me = getMeta('me');
 export const movedToAccountId = getMeta('moved_to_account_id');
-export const visibleReactions = getMeta('visible_reactions');
 export const owner = getMeta('owner');
 export const profile_directory = getMeta('profile_directory');
 export const reduceMotion = getMeta('reduce_motion');