chuckya/app
Claire 6da135a493
Fix reviving revoked sessions and invalidating login (#16943)
Up until now, we have used Devise's Rememberable mechanism to re-log users
after the end of their browser sessions. This mechanism relies on a signed
cookie containing a token. That token was stored on the user's record,
meaning it was shared across all logged in browsers, meaning truly revoking
a browser's ability to auto-log-in involves revoking the token itself, and
revoking access from *all* logged-in browsers.

We had a session mechanism that dynamically checks whether a user's session
has been disabled, and would log out the user if so. However, this would only
clear a session being actively used, and a new one could be respawned with
the `remember_user_token` cookie.

In practice, this caused two issues:
- sessions could be revived after being closed from /auth/edit (security issue)
- auto-log-in would be disabled for *all* browsers after logging out from one
  of them

This PR removes the `remember_token` mechanism and treats the `_session_id`
cookie/token as a browser-specific `remember_token`, fixing both issues.
2021-11-06 00:13:58 +01:00
..
chewy Change tootctl search deploy algorithm (#14300) 2020-07-14 18:10:35 +02:00
controllers Fix reviving revoked sessions and invalidating login (#16943) 2021-11-06 00:13:58 +01:00
helpers Add Northern Kurdish locale as requested by translator. It already has a project started on Crowdin. (#16548) 2021-10-14 21:02:54 +02:00
javascript ran yarn manage:translations en (#16912) 2021-10-28 05:29:49 +02:00
lib Add support for structured data and more OpenGraph tags to link cards (#16938) 2021-11-05 23:23:05 +01:00
mailers Prepare Mastodon for Rails 6 (#15911) 2021-03-17 10:09:55 +01:00
models Fix reviving revoked sessions and invalidating login (#16943) 2021-11-06 00:13:58 +01:00
policies Add ability to skip sign-in token authentication for specific users (#16427) 2021-07-08 05:31:28 +02:00
presenters Add graphs and retention metrics to admin dashboard (#16829) 2021-10-14 20:44:59 +02:00
serializers Add graphs and retention metrics to admin dashboard (#16829) 2021-10-14 20:44:59 +02:00
services Add support for structured data and more OpenGraph tags to link cards (#16938) 2021-11-05 23:23:05 +01:00
validators Minor memory optimizations (#16507) 2021-10-14 21:04:57 +02:00
views Add graphs and retention metrics to admin dashboard (#16829) 2021-10-14 20:44:59 +02:00
workers Fix AccountNote not having a maximum length (#16942) 2021-11-06 00:12:25 +01:00