Commit graph

17960 commits

Author SHA1 Message Date
Jeremy Kescher
5d0a1a7b74
Fix invalidating status reactions when they already exist
Co-authored-by: Plastikmensch <plastikmensch@users.noreply.github.com>
2023-05-10 21:07:32 +02:00
Jeremy Kescher
bcc8e89b08
status_reaction_fabricator: Use a unicode emoji instead of "MyString"
Co-authored-by: Plastikmensch <plastikmensch@users.noreply.github.com>
2023-05-10 21:07:24 +02:00
Jeremy Kescher
a167d715c9
api.rb: Remove resources line that wasn't in routes.rb anymore
Co-authored-by: Plastikmensch <plastikmensch@users.noreply.github.com>
2023-05-10 21:07:17 +02:00
Jeremy Kescher
e2865c0781
Remove German translation for setting_visible_reactions 2023-05-10 00:43:56 +02:00
Jeremy Kescher
873e183d4d
Remove old french emoji reaction-related strings 2023-05-10 00:34:52 +02:00
Jeremy Kescher
2742a9958b
Introduce visible reactions default setting 2023-05-10 00:19:41 +02:00
Jeremy Kescher
bf2c39ec7f
Re-apply schema version 2023-05-10 00:18:32 +02:00
Jeremy Kescher
300c2288ba
Fix visible reactions setting not applying 2023-05-10 00:15:19 +02:00
Jeremy Kescher
c50ccdf69d
eslint fix 2023-05-10 00:11:26 +02:00
Jeremy Kescher
63e9572b94
Remove further leftover makeCustomEmojiMap references 2023-05-10 00:05:39 +02:00
Jeremy Kescher
a1395de405
Remove duplicate notification_mailer definition 2023-05-10 00:02:17 +02:00
Jeremy Kescher
f28f2bf216
Fix n+1 query for move emoji reaction settings migration 2023-05-10 00:00:06 +02:00
Jeremy Kescher
845d1be5ca
Run rubocop -a 2023-05-09 23:41:48 +02:00
Jeremy Kescher
f3c8de9379
Removed unused imports in status_container.js 2023-05-09 23:37:40 +02:00
Jeremy Kescher
3ecb6ce63e
Add back missing visibleReactions variable to both initial_state.js files 2023-05-09 23:37:34 +02:00
Jeremy Kescher
711fee1508
Add missing visible_reactions to vanilla initial_state typedef 2023-05-09 23:20:44 +02:00
Jeremy Kescher
010569da7b
Fix max_reactions typedef 2023-05-09 23:18:20 +02:00
Jeremy Kescher
42d494dda3
Move reaction endpoints from route.rb to api.rb 2023-05-09 23:08:13 +02:00
neatchee
81c3d63f01
Remove stale/missed references to makeCustomEmojiMap / EmojiMap 2023-05-09 22:58:59 +02:00
Jeremy Kescher
530167dff5
Reactions: Return 404 when status should not be visible, asynchronous unreact 2023-05-09 22:58:58 +02:00
Jeremy Kescher
5fd81b6144
Add missing authorization to ReactService 2023-05-09 22:58:58 +02:00
neatchee
6af0296abc
Restore loc files for non-English languages; CrowdIn should handle this 2023-05-09 22:58:58 +02:00
Jeremy Kescher
92d6dc61eb
Update emoji reaction patches 2023-05-09 22:58:58 +02:00
neatchee
214eee241b
Fix placement of reactions bar for new threading UI 2023-05-09 22:58:58 +02:00
Jeremy Kescher
5b7d1d5281
Migrate emoji reactions 2023-05-09 22:58:56 +02:00
neatchee
1b76bb6bcc
Remove old .js locale files accidentally restored during rebase 2023-05-09 22:58:42 +02:00
Ivan Rodriguez
55303adfef
Keep emoji picker within screen bounds
Adds the `flip` prop to `<Overlay>`. Fixes #40
2023-05-09 22:58:42 +02:00
neatchee
f577764472
Fix rebase issues 2023-05-09 22:58:42 +02:00
neatchee
a789208939
Per PR suggestion, split name and domain, and look for emoji ID, for unreact, so remote emoji's can be unreacted 2023-05-09 22:58:42 +02:00
fef
ba68e3e0dc
move emoji reaction strings to locales-glitch 2023-05-09 22:58:39 +02:00
Jeremy Kescher
d23b8adc8b
Fix status reactions preventing an on_cascade delete 2023-05-09 22:56:46 +02:00
fef
bec3c13cad
bypass reaction limit for foreign accounts 2023-05-09 22:56:46 +02:00
fef
9b2cfc3191
fix 404 when reacting with Keycap Number Sign
The Unicode sequence for this emoji starts with an
ASCII # character, which the browser's URI parser
truncates before sending the request to the
backend.
2023-05-09 22:56:46 +02:00
fef
b7d563611f
fix status action bar after upstream changes 2023-05-09 22:56:46 +02:00
fef
9d1467a364
fix schema after rebase 2023-05-09 22:56:46 +02:00
fef
c05db8c765
delete reaction notifications when deleting status 2023-05-09 22:56:46 +02:00
fef
c2209aca12
support reacting with foreign custom emojis 2023-05-09 22:56:44 +02:00
fef
b46adb9a1d
properly disable reactions when not logged in 2023-05-09 22:56:07 +02:00
fef
9ad49a191c
serialize custom emoji reactions properly for AP
Akkoma and possibly others expect the `tag` field
in an EmojiReact activity to be an array, not just
a single object, so it's being wrapped into one
now.  I'm not entirely sure whether this is the
idiomatic way of doing it tbh, but it works fine.
2023-05-09 22:56:07 +02:00
fef
f0d129fabe
also disable reaction buttons in vanilla flavour 2023-05-09 22:56:07 +02:00
fef
245f5b3f2f
disable reaction button when not signed in 2023-05-09 22:56:07 +02:00
fef
01723aef2b
fix image for new custom emoji reactions 2023-05-09 22:56:07 +02:00
fef
122abba7bc
run i18n-tasks normalize 2023-05-09 22:56:05 +02:00
fef
83bffa8b3c
display external custom emoji reactions properly
Using an emoji map was completely unnecessary in
the first place, because the reaction list from
the API response includes URLs for every custom
emoji anyway.  The reaction list now also contains
a boolean field indicating whether it is an
external custom emoji, which is required because
people should only be able to react with Unicode
emojis and local custom ones, not with custom
emojis from other servers.
2023-05-09 22:55:28 +02:00
fef
38346d52ef
handle incoming custom emoji reactions properly 2023-05-09 22:55:28 +02:00
fef
fe084475e9
support Undo action for EmojiReaction 2023-05-09 22:55:28 +02:00
fef
d800559866
download remote custom emojis from reactions
Emoji reactions containing custom emojis from
remote instances were assumed to already have
been downloaded and stored in the database.
This might obviously not be the case.
2023-05-09 22:55:28 +02:00
fef
7792235a89
sanitize setting for number of visible reactions
This is kind of a hack, but the lack of
validation for settings unfortunately makes it
necessary.
2023-05-09 22:55:28 +02:00
Jeremy Kescher
5482045c22
Add reaction limit to instance serializer 2023-05-09 22:55:28 +02:00
fef
a97b0fd62b
fix padding on posts without reactions
The margins of the elements above and below the
main reaction list element overlapped before
reactions were added.  Adding display: none to
empty reaction bars restores this exact look.
2023-05-09 22:55:28 +02:00